Stop FreshRSS traffic from health probes #35

Open
turnercore wants to merge 3 commits from fix/rss-health-cache into main
Contributor

The RSS module health endpoint performed three authenticated FreshRSS requests on every health probe. With frequent Body and container probes, this created unnecessary DNS traffic, especially AAAA lookups against the IPv4-only AdGuard rewrite.\n\nThis change makes /health return the last backend status recorded by the normal poll loop, keeps /healthz as the cheap liveness endpoint, and adds a small stdlib HTTP/1.1 connection pool so actual upstream calls can reuse connections. Poll failures still update health to down.\n\nTests: focused RSS, real module contract, architecture, module contract, and discovery tests pass (76 passed). The full suite was also attempted but currently hits the unrelated env-key inventory mismatch on main.

The RSS module health endpoint performed three authenticated FreshRSS requests on every health probe. With frequent Body and container probes, this created unnecessary DNS traffic, especially AAAA lookups against the IPv4-only AdGuard rewrite.\n\nThis change makes /health return the last backend status recorded by the normal poll loop, keeps /healthz as the cheap liveness endpoint, and adds a small stdlib HTTP/1.1 connection pool so actual upstream calls can reuse connections. Poll failures still update health to down.\n\nTests: focused RSS, real module contract, architecture, module contract, and discovery tests pass (76 passed). The full suite was also attempted but currently hits the unrelated env-key inventory mismatch on main.
Avoid FreshRSS requests from RSS health probes
Some checks failed
ci / supply-chain (pull_request) Failing after 8s
ci / python-tests (pull_request) Has been cancelled
ci / dev-smoke (pull_request) Has been cancelled
ci / production-manifests (pull_request) Has been cancelled
ci / rust-tests (pull_request) Has been cancelled
ci / frontend-tests (pull_request) Has been cancelled
ci / container-build (pull_request) Has been cancelled
3c4ec0d507
Format RSS health changes
Some checks failed
ci / supply-chain (pull_request) Failing after 7s
ci / python-tests (pull_request) Failing after 10s
ci / dev-smoke (pull_request) Failing after 1s
ci / production-manifests (pull_request) Failing after 1s
ci / rust-tests (pull_request) Successful in 8s
ci / frontend-tests (pull_request) Failing after 10s
ci / container-build (pull_request) Has been skipped
a390d9dc6b
Ignore local agent artifacts
Some checks failed
ci / supply-chain (pull_request) Failing after 9s
ci / python-tests (pull_request) Failing after 9s
ci / dev-smoke (pull_request) Failing after 2s
ci / production-manifests (pull_request) Failing after 2s
ci / rust-tests (pull_request) Successful in 9s
ci / frontend-tests (pull_request) Failing after 10s
ci / container-build (pull_request) Has been skipped
c54e4d0386
Some checks failed
ci / supply-chain (pull_request) Failing after 9s
ci / python-tests (pull_request) Failing after 9s
ci / dev-smoke (pull_request) Failing after 2s
ci / production-manifests (pull_request) Failing after 2s
ci / rust-tests (pull_request) Successful in 9s
ci / frontend-tests (pull_request) Failing after 10s
ci / container-build (pull_request) Has been skipped
This pull request has changes conflicting with the target branch.
  • .gitignore
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/rss-health-cache:fix/rss-health-cache
git switch fix/rss-health-cache

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff fix/rss-health-cache
git switch fix/rss-health-cache
git rebase main
git switch main
git merge --ff-only fix/rss-health-cache
git switch fix/rss-health-cache
git rebase main
git switch main
git merge --no-ff fix/rss-health-cache
git switch main
git merge --squash fix/rss-health-cache
git switch main
git merge --ff-only fix/rss-health-cache
git switch main
git merge fix/rss-health-cache
git push origin main
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
daisy/embodied-ai!35
No description provided.